New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UserDataRepository breaks dependecy rules #65
Comments
@Trikke Kudos for such a great explanation! |
@android10 happy to help here. You got me interested in proper architecture on android and i've been digging deeper ever since. Seems natural to help a bit with all the questions! |
@Trikke good to hear! I really appreciate your help buddy. |
thanks guys 2015-11-12 13:37 GMT+01:00 Fernando Cejas notifications@github.com:
|
UseCase output port Interface should be placed in the same UseCase layer, according to the diagram. But the question was about data layer output Interface (UserRepository) being placed in UseCase, which is domain layer.
But the name 'UserRepository' of outside circle (domain) is mentioned by data - the inner circle. |
@ildar2 data is not the inner circle. it does not solve your problem (only provides data), domain layer does and it is where your logic sits. There is no dependency rule break up. 😄 |
Hi,
didn't UserDataRepository breaks dependency rules? Class is from data layer but implements userrepository interface which is from domain layer.
thanks
rohliq
The text was updated successfully, but these errors were encountered: