Clean up some UB #10175
Merged
Clean up some UB #10175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodaFi
force-pushed
the
that-one-broom-scene-in-fantasia
branch
from
75ecfd9
to
2275fde
Compare
* The SILBuilder could potentially reference itself during its own initialization if a valid insertion point was left around and a new basic block was created. Move basic block creation after the initializer instead. * CSDiag was comparing canonical types for equality directly, which leads to mixed-type comparisons if one side of the comparison is nullptr. Use isEqual instead.
CodaFi
force-pushed
the
that-one-broom-scene-in-fantasia
branch
from
2275fde
to
3b26466
Compare
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SILBuilder could potentially reference itself during its own
initialization if a valid insertion point was left around and a
new basic block was created. Move basic block creation after the
initializer instead.
CSDiag was comparing canonical types for equality directly, which
leads to mixed-type comparisons if one side of the comparison is nullptr.
Use isEqual instead.
God, I love UBSan