Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests to run always specified on command line, even if running all tests in executable #18

Closed
DominikGrabiec opened this issue Jan 8, 2016 · 1 comment
Closed

Tests to run always specified on command line, even if running all tests in executable #18

DominikGrabiec opened this issue Jan 8, 2016 · 1 comment
Assignees
@csoltenborn
Labels
bug

Comments

@DominikGrabiec
Copy link

The bug is that all of the tests suites are specified in the filter on the command line if the whole project is run or even run all is selected.

This occurs because there is a bug in the CommandLineGenerator.AllTestCasesOfExecutableAreRun function. It assumes that the AllTestCases variable only contains tests for that executable, but it actually contains all of the tests for all executables to be run.

To reproduce:

  • Make a solution with two test executable projects and add tests to both.
  • Put a breakpoint in one of the tests
  • In Test Explorer select the project view and right click on one project and "Debug Selected Tests" or even "Debug All".
  • When the breakpoint is hit, check Process Explorer for the test executable and examine the command line parameters.

If running all the tests in an executable there should be no command line parameters.
@csoltenborn csoltenborn mentioned this issue Jan 8, 2016
Closed
@csoltenborn
Copy link
Owner

Thanks for your excellent bug report. However, I think the assumption in CommandLineGenerator should be fine - I decided to select the test cases for the according executable already in SequentialTestRunner, which should fix the issue, too, and additionally be more consistent with what shall actually happen.

@csoltenborn csoltenborn added the bug label Jan 8, 2016
@csoltenborn csoltenborn self-assigned this Jan 8, 2016
@drzoidberg33 drzoidberg33 mentioned this issue Sep 26, 2017
Closed
@csoltenborn csoltenborn mentioned this issue Dec 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csoltenborn csoltenborn

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DominikGrabiec @csoltenborn