Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test result names aren't properly published to tfs / trx #25

Closed
sirotnikov opened this issue Jan 31, 2016 · 1 comment
Closed

Test result names aren't properly published to tfs / trx #25

sirotnikov opened this issue Jan 31, 2016 · 1 comment
Assignees
@csoltenborn
Labels
bug

Comments

@sirotnikov
Copy link

TFS was complaining about missing test names.

I traced it down to what appears to be an omission in XmlTestResultParses.cs:91

private TestResult ParseTestResult(XmlNode testcaseNode)
{
    string className = testcaseNode.Attributes["classname"].InnerText;
    string testCaseName = testcaseNode.Attributes["name"].InnerText;
    string qualifiedName = className + "." + testCaseName;

    [...]

    TestResult testResult = new TestResult(testCase)
    {
        ComputerName = Environment.MachineName,
91:     DisplayName = " ";      // shouldn't this be DisplayName = qualifiedName ?
    };

Is this a mistake or is there some reason for it?
@csoltenborn csoltenborn added the bug label Feb 1, 2016
@csoltenborn
Copy link
Owner

There's indeed a reason - information in VS' details pane is rather redundant, so we wanted to use the space occupied by the DisplayName for other information (i.e., clearly point out to the user if a test has crashed). However, that DisplayName is also used when running tests via VsTest.Console.exe (which I happened to find out last night), so that's apparently not an option.

I will commit a fix in the next minutes. We will release a fixed version as soon as we have figured out #21 .

csoltenborn added a commit that referenced this issue Feb 1, 2016
@csoltenborn
bugfix: reusing DisplayName of TestResult for other info had unintend…
39ee7d6 
…ed side effects (#25)
@csoltenborn csoltenborn self-assigned this Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csoltenborn csoltenborn

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@csoltenborn @sirotnikov