Rename to electron #1389

kevinsawicki · 2015-04-08T17:06:43Z

When Atom Shell started over two years ago, its one and only consumer was the Atom editor.

And so the original Atom Shell name was just a stopgap to refer to the Chromium/Node integration pieces and the native bits for window management and OS integrations such as the clipboard, the dock, etc.

But over the last two years Atom Shell has grown and matured to become a framework that isn't just for building text editors. People are now using it to build email clients, design tools, chat clients, and video players.

It deserves a better name that decouples it from the Atom editor association and allows it to stand on its own and continue to become the easiest way to build native apps using web tech.

So the new name will be ⚡ electron ⚡ and this pull request will update all the places in the code and the docs to this new name.

/cc @atom/core @atom/non-github-maintainers

thomasjo · 2015-04-08T17:38:20Z

Awesome! ✨
On Apr 8, 2015 7:06 PM, "Kevin Sawicki" notifications@github.com wrote:

When Atom Shell started over two years ago, its one and only consumer was
the Atom https://github.com/atom/atom editor.

And so the original Atom Shell name was just a stopgap to refer to the
Chromium/Node integration pieces and the native bits for window management
and OS integrations such as the clipboard, the dock, etc.

But over the last two years Atom Shell has grown and matured to become a
framework that isn't just for building text editors. People are now using
it to build email clients, design tools, chat clients, and video players.

It deserves a better name that decouples it from the Atom editor
association and allows it to stand on its own and continue to become the
easiest way to build native apps using web tech.

So the new name will be [image: ⚡] electron [image: ⚡] and this
pull request will update all the places in the code and the docs to this
new name.

https://camo.githubusercontent.com/326b68277c9d074b4de4d324c8a2274da219bc4b/68747470733a2f2f33332e6d656469612e74756d626c722e636f6d2f36383838396233303732373833643039333730303639363230653165356264632f74756d626c725f6d757477766a4c5a387431736a77777a736f315f3530302e676966

/cc @atom/core https://github.com/orgs/atom/teams/core
@atom/non-github-maintainers

https://github.com/orgs/atom/teams/non-github-maintainers

You can view, comment on, or merge this pull request online at:

#1389
Commit Summary

Begin Atom Shell -> Electron rename

File Changes

M README.md
https://github.com/atom/atom-shell/pull/1389/files#diff-0 (2)

Patch Links:

https://github.com/atom/atom-shell/pull/1389.patch

https://github.com/atom/atom-shell/pull/1389.diff

—
Reply to this email directly or view it on GitHub
#1389.

marekhrabe · 2015-04-08T17:44:40Z

nice one, guys! we love it at @avocode :)

50Wliu · 2015-04-08T17:46:33Z

atom/browser/default_app/index.html

@@ -72,7 +72,7 @@
    };
  </script>

-  <h2 style="-webkit-app-region: drag">Welcome to Atom Shell</h2>
+  <h2 style="-webkit-app-region: drag">Welcome to Electron</h2>

  <p>
  To run your app with atom-shell, execute the following command under your


Forgot to change it here

YurySolovyov · 2015-04-08T18:26:42Z

.asar makes less sense with Electron, but it is not a huge deal.

anaisbetts · 2015-04-08T18:39:44Z

Yesssssss

JoshTheDerf · 2015-04-08T23:14:24Z

Oooh! Sounds nice!
"Quark" sounds better IMO though.

mnquintana · 2015-04-09T09:49:43Z

@YuriSolovyov Although then we'd end up with .ear 😝

YurySolovyov · 2015-04-09T10:34:22Z

@mnquintana it does not have to be ARchive, it can be a PACKage, or something.

mnquintana · 2015-04-09T15:34:51Z

Now that I think about it, .elar wouldn't be bad.

YurySolovyov · 2015-04-09T15:38:48Z

@kevinsawicki are you going to design a logo too?

anaisbetts · 2015-04-09T16:17:20Z

Now that I think about it, .elar wouldn't be bad.

I think it'd be super cool if we had as few non-breaking changes to existing code as possible just to change a marketing name, so far we're doing pretty good

kevinsawicki · 2015-04-09T16:31:41Z

are you going to design a logo too?

Eventually yes, a new site is being worked on as well.

thedaniel · 2015-04-09T16:52:28Z

I think it'd be super cool if we had as few non-breaking changes to existing code as possible just to change a marketing name, so far we're doing pretty good

☝️

It doesn't matter what the archive format is called, .asar is fine forever.

thomasjo · 2015-04-09T16:57:00Z

It doesn't matter what the archive format is called, .asar is fine forever.

This.

If people are super bothered, we can imagine .asar being an abbreviation of Awesome Software ARchive or whatever.

mnquintana · 2015-04-09T16:59:48Z

I think it'd be super cool if we had as few non-breaking changes to existing code as possible just to change a marketing name, so far we're doing pretty good

Haha no worries, I was just throwing around names not-so-seriously

lee-dohm · 2015-04-10T15:57:59Z

Posted a reference on Discuss:

https://discuss.atom.io/t/in-case-you-hadnt-heard-atom-shell-is-being-renamed-electron/16098

The npm instructions are removed for now, will add it back when we had electron in npm registry.

Electron icon

kevinsawicki · 2015-04-16T16:59:03Z

@zcbenz anything left to do here before shipping this?

Want to add a task list to the pull request body if there are still remaining items?

jweinstein · 2015-04-16T18:03:08Z

I am impressed by this diff.

anaisbetts · 2015-04-16T19:26:43Z

atom/app/atom_main_delegate_mac.mm

-                         .Append("MacOS")
-                         .Append(PRODUCT_NAME " Helper");
+  base::FilePath frameworks_path = GetFrameworksPath();
+  base::FilePath helper_path = GetHeleprAppPath(frameworks_path,


Rename to electron

jprichardson · 2015-04-20T16:10:47Z

Been using atom-shell for a few months. Electron is an excellent name and is better for marketing. I realize that many devs don't care about this, but it affects us all whether we know it or not. The bigger the community for Electron, the better it is all for all of us. Bravo!

kevinsawicki · 2015-04-20T16:14:52Z

💚 💜 💙

Github has changed the name of atom-shell to electron as per electron/electron#1389

kevinsawicki added 2 commits April 8, 2015 09:50

Begin Atom Shell -> Electron rename

6ca4623

Atom Shell -> Electron

6615ef1

50Wliu reviewed Apr 8, 2015
View reviewed changes

zcbenz added 10 commits April 12, 2015 21:49

Merge branch 'master' into rename-to-electron

43fe82e

Use "project_name" in atom.gyp as default target in build.py

4e7ed50

Rename some functions in bootstrap.py

af37af3

Use atom.gyp to generate filenamse in create-dist.py

f8d64ef

Use atom.gyp to generate paths in test.py

6ba57dc

Update tmp dir prefix

b413acd

Fix uploading index.json under OS X

7255962

Use atom.gyp to generate filenames in upload-windows-pdb.py

74be99d

mac: Allow modifying helper app's name

4353c6d

Don't hard code exec path in child_process.fork

a72c7b3

zcbenz and others added 14 commits April 14, 2015 14:15

mac: Avoid making frameworks_path for twice

ecc14dd

Set process.versions['electron']

b86f149

Don't hard-code product name in crash-repoter

c6c305a

Rename hard-coded application names in code

2d8d328

Change the names in specs

1200d64

mac: Generate Info.plist from gyp variables

e04c58f

Change the window class names

c746827

atom => electron in atom.gyp

49c82b3

mac: Remove "Atom"s from default menu

14e05c6

Forgot to set default version in crash reporter

76316e5

docs: Update links in README

d878bd3

The npm instructions are removed for now, will add it back when we had electron in npm registry.

docs: Atom Shell => Electron

d268223

docs: Build for 64bit target on Windows

1f1cb12

Replace icons

95250f4

simurai mentioned this pull request Apr 16, 2015

Electron icon #1430

Merged

Merge pull request #1430 from simurai/rename-to-electron-icon

2f9de5a

Electron icon

anaisbetts reviewed Apr 16, 2015
View reviewed changes

zcbenz added 3 commits April 17, 2015 11:59

docs: Update the rebranding guide

b0b6747

Use product_name for generating zip archives

eb6fa46

Fix typo

0bab50e

zcbenz added a commit that referenced this pull request Apr 17, 2015

Merge pull request #1389 from atom/rename-to-electron

cd0aa4a

Rename to electron

zcbenz merged commit cd0aa4a into master Apr 17, 2015

zcbenz deleted the rename-to-electron branch April 17, 2015 07:22

YurySolovyov mentioned this pull request Apr 17, 2015

Cannot find atom-shell v0.22.3 from GitHub [Error: Not Found] atom/atom#6415

Closed

martinchooooooo added a commit to martinchooooooo/LightTable that referenced this pull request Apr 23, 2015

Update build scripts for atom-shell name change to electron

3e270f7

Github has changed the name of atom-shell to electron as per electron/electron#1389

martinchooooooo mentioned this pull request Apr 23, 2015

Update build scripts for atom-shell name change to electron LightTable/LightTable#1892

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename to electron #1389

Rename to electron #1389

kevinsawicki commented Apr 8, 2015

thomasjo commented Apr 8, 2015

https://github.com/orgs/atom/teams/non-github-maintainers

marekhrabe commented Apr 8, 2015

50Wliu Apr 8, 2015

YurySolovyov commented Apr 8, 2015

anaisbetts commented Apr 8, 2015

JoshTheDerf commented Apr 8, 2015

mnquintana commented Apr 9, 2015

YurySolovyov commented Apr 9, 2015

mnquintana commented Apr 9, 2015

YurySolovyov commented Apr 9, 2015

anaisbetts commented Apr 9, 2015

kevinsawicki commented Apr 9, 2015

thedaniel commented Apr 9, 2015

thomasjo commented Apr 9, 2015

mnquintana commented Apr 9, 2015

lee-dohm commented Apr 10, 2015

kevinsawicki commented Apr 16, 2015

jweinstein commented Apr 16, 2015

anaisbetts Apr 16, 2015

jprichardson commented Apr 20, 2015

kevinsawicki commented Apr 20, 2015

Rename to electron #1389

Rename to electron #1389

Conversation

kevinsawicki commented Apr 8, 2015

thomasjo commented Apr 8, 2015

https://github.com/orgs/atom/teams/non-github-maintainers

marekhrabe commented Apr 8, 2015

50Wliu Apr 8, 2015

Choose a reason for hiding this comment

YurySolovyov commented Apr 8, 2015

anaisbetts commented Apr 8, 2015

JoshTheDerf commented Apr 8, 2015

mnquintana commented Apr 9, 2015

YurySolovyov commented Apr 9, 2015

mnquintana commented Apr 9, 2015

YurySolovyov commented Apr 9, 2015

anaisbetts commented Apr 9, 2015

kevinsawicki commented Apr 9, 2015

thedaniel commented Apr 9, 2015

thomasjo commented Apr 9, 2015

mnquintana commented Apr 9, 2015

lee-dohm commented Apr 10, 2015

kevinsawicki commented Apr 16, 2015

jweinstein commented Apr 16, 2015

anaisbetts Apr 16, 2015

Choose a reason for hiding this comment

jprichardson commented Apr 20, 2015

kevinsawicki commented Apr 20, 2015