Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement EventTarget interface for WebSocket. #2599

Closed
wants to merge 1 commit into from
Closed

Implement EventTarget interface for WebSocket. #2599

wants to merge 1 commit into from

Conversation

leeyeh
Copy link
Contributor

@leeyeh leeyeh commented Sep 8, 2015

close #2583

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Sep 8, 2015
@leeyeh
Copy link
Contributor Author

leeyeh commented Sep 8, 2015

The test passed locally. It seems that the new node package event-target-shim is not installed properly in travis. Maybe the cache node_modules config is relevant.

@Hybrid-Force Hybrid-Force mentioned this pull request Sep 9, 2015
Closed
@ide ide mentioned this pull request Sep 20, 2015
Closed
@ide
Copy link
Contributor

ide commented Sep 20, 2015

cc @frantic @vjeux this PR looks good and web sockets are mostly Community Responsibility. What's the process for adding new npm dependencies? Should PRs update npm-shrinkwrap.json?

@vjeux
Copy link
Contributor

vjeux commented Sep 22, 2015

@ide ping someone from the team to pull the npm module internally. Sucks but well :(

@ide
Copy link
Contributor

ide commented Sep 22, 2015

OK. I am accepting this. When this is imported, it will be necessary for someone at FB to download the "event-target-shim" module and rebuild npm-shrinkwrap.json.

@vjeux vjeux self-assigned this Sep 22, 2015
@satya164 satya164 mentioned this pull request Sep 27, 2015
Closed
@ide
Copy link
Contributor

ide commented Sep 30, 2015

@vjeux could you or someone else familiar with adding a new npm module help import this? There are some Android websocket diffs that are blocked on this one.

@vjeux
Copy link
Contributor

vjeux commented Oct 1, 2015

@facebook-github-bot import

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/808094802641123/int_phab to review.

@vjeux
Copy link
Contributor

vjeux commented Oct 1, 2015

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/808094802641123/int_phab to review.

ghost pushed a commit that referenced this pull request Oct 2, 2015
@leeyeh
Implement EventTarget interface for WebSocket.
626b551 
Summary: close #2583Closes #2599

Reviewed By: @​svcscm

Differential Revision: D2498641

Pulled By: @vjeux
@vjeux vjeux closed this Oct 2, 2015
MattFoley pushed a commit to skillz/react-native that referenced this pull request Nov 9, 2015
@leeyeh
Implement EventTarget interface for WebSocket.
25b62d0 
Summary: close #2583Closes facebook#2599

Reviewed By: @​svcscm

Differential Revision: D2498641

Pulled By: @vjeux
Crash-- pushed a commit to Crash--/react-native that referenced this pull request Dec 24, 2015
@leeyeh @Crash--
Implement EventTarget interface for WebSocket.
26d7a54 
Summary: close #2583Closes facebook#2599

Reviewed By: @​svcscm

Differential Revision: D2498641

Pulled By: @vjeux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vjeux vjeux

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WebSocket] WebSocket polyfill does not implement EventTarget interface
4 participants
@leeyeh @ide @vjeux @facebook-github-bot