This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
e161d6e
commit 5594929
Showing
1 changed file
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5594929
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fzaninotto What about adding StyleCI? Then all commits and PRs will be checked automagically.
If you're up to it I can submit a PR.
5594929
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already check both style and unit tests in the CI build, see
Faker/.travis.yml
Line 21 in 5594929
5594929
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fzaninotto Running cs checks on travis is a bad idea. You surely want to tell if the tests fail separately to if the cs fails, straight away.
5594929
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the "right away". You mean for developers, before they submit a PR? Well, they have a
make sniff
command, I can't do more. And I do want a CS check for every PR, so instead of asking for a second build, I put it all in the same build. I don't see the problem.