add: use preload-index and fscache for performance #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teach "add" to use preload-index and fscache features to improve performance on very large repositories. During an "add", a call is made to run_diff_files() which calls check_remove() for each index-entry. This calls lstat(). On Windows, the fscache code intercepts the lstat() calls and builds a private cache using the FindFirst/FindNext routines, which are much faster. Somewhat independent of this, is the preload-index code which distributes some of the start-up costs across multiple threads. Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
|
Excellent! |
|
Oops, I just realized something... (Please note that So maybe the best course of action is to keep the original I am thinking about something like this: dscho@8f26c6a What do you think @jeffhostetler ? |
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Nov 23, 2016
Performance of `git add` in large worktrees [was improved](git-for-windows/git#971). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 24, 2016
…er/add_preload_fscache add: use preload-index and fscache for performance
dscho
pushed a commit
that referenced
this pull request
Nov 29, 2016
…fscache add: use preload-index and fscache for performance
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 29, 2016
…er/add_preload_fscache add: use preload-index and fscache for performance
dscho
pushed a commit
that referenced
this pull request
Nov 30, 2016
…fscache add: use preload-index and fscache for performance
dscho
added a commit
that referenced
this pull request
Dec 6, 2016
…fscache add: use preload-index and fscache for performance
dscho
added a commit
that referenced
this pull request
Dec 12, 2016
…fscache add: use preload-index and fscache for performance
dscho
added a commit
that referenced
this pull request
Jan 11, 2017
…fscache add: use preload-index and fscache for performance
dscho
added a commit
that referenced
this pull request
Jan 18, 2017
…fscache add: use preload-index and fscache for performance
dscho
added a commit
that referenced
this pull request
Jan 18, 2017
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 18, 2017
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 18, 2017
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 18, 2017
…fscache add: use preload-index and fscache for performance
dscho
added a commit
that referenced
this pull request
Jan 24, 2017
…fscache add: use preload-index and fscache for performance
dscho
added a commit
that referenced
this pull request
Jan 24, 2017
…fscache add: use preload-index and fscache for performance
dscho
added a commit
that referenced
this pull request
Jan 24, 2017
…fscache add: use preload-index and fscache for performance
dscho
added a commit
that referenced
this pull request
Jan 25, 2017
…fscache add: use preload-index and fscache for performance
dscho
added a commit
that referenced
this pull request
Jan 25, 2017
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 22, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 22, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 23, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 23, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 24, 2024
…fscache add: use preload-index and fscache for performance
dscho
added a commit
to microsoft/git
that referenced
this pull request
Apr 24, 2024
…er/add_preload_fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 24, 2024
…fscache add: use preload-index and fscache for performance
dscho
added a commit
that referenced
this pull request
Apr 25, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 25, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 25, 2024
…fscache add: use preload-index and fscache for performance
dscho
added a commit
that referenced
this pull request
Apr 25, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 25, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 26, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 26, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 26, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 26, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 26, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 27, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 27, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 29, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 29, 2024
…fscache add: use preload-index and fscache for performance
dscho
added a commit
to microsoft/git
that referenced
this pull request
Apr 29, 2024
…er/add_preload_fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 29, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 29, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 4, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 4, 2024
…fscache add: use preload-index and fscache for performance
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 9, 2024
…fscache add: use preload-index and fscache for performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach "add" to use preload-index and fscache features
to improve performance on very large repositories.
During an "add", a call is made to run_diff_files()
which calls check_remove() for each index-entry. This
calls lstat(). On Windows, the fscache code intercepts
the lstat() calls and builds a private cache using the
FindFirst/FindNext routines, which are much faster.
Somewhat independent of this, is the preload-index code
which distributes some of the start-up costs across
multiple threads.
Signed-off-by: Jeff Hostetler jeffhost@microsoft.com