string-list: use ALLOC_GROW macro when reallocing string_list #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ALLOC_GROW() macro when reallocing a string_list array rather than simply increasing it by 32. This is a performance optimization. During status on a very large repo and there are many changes, a significant percentage of the total run time was spent reallocing the wt_status.changes array. This change decreased the time in wt_status_collect_changes_worktree() from 125 seconds to 45 seconds on my very large repository. Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
|
Wow, that is an impressive performance improvement for such an innocuous change! Thanks! |
dscho
added a commit
that referenced
this pull request
Dec 12, 2016
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Dec 23, 2016
The `status` operation [was made faster](git-for-windows/git#991) in large worktrees with many changes. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
that referenced
this pull request
Jan 11, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Jan 18, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Jan 18, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 18, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 18, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 18, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Jan 24, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Jan 24, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Jan 24, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Jan 25, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Jan 25, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Jan 25, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Jan 25, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
to dscho/git
that referenced
this pull request
Feb 1, 2017
…er/string_list_realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Feb 2, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Feb 2, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Feb 2, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Feb 2, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Feb 2, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Feb 3, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Mar 21, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 21, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 21, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Mar 22, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 23, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 24, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Mar 24, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 24, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 25, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Mar 26, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 27, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 27, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 28, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Mar 30, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 30, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 30, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 30, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Apr 2, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 12, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
dscho
added a commit
that referenced
this pull request
Apr 12, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 13, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 13, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 17, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 17, 2017
…realloc string-list: use ALLOC_GROW macro when reallocing string_list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ALLOC_GROW() macro when reallocing a string_list array
rather than simply increasing it by 32. This is a performance
optimization.
During status on a very large repo and there are many changes,
a significant percentage of the total run time was spent
reallocing the wt_status.changes array.
This change decreased the time in wt_status_collect_changes_worktree()
from 125 seconds to 45 seconds on my very large repository.
Signed-off-by: Jeff Hostetler jeffhost@microsoft.com