Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON API 1.0 #413

Closed
wants to merge 1 commit into from
Closed

JSON API 1.0 #413

wants to merge 1 commit into from

Conversation

dgeb
Copy link
Member

@dgeb dgeb commented Mar 6, 2015

This marks the first stable release of JSON API. Any future changes to the base spec will be backward compatible.

Thanks to our wonderful community of contributors for guiding JSON API to this point!

@ethanresnick
Copy link
Member

Awesome! Thanks to you, @steveklabnik, and @wycats for working so long to shepherd this to 1.0!

(Now the fun starts of updating my library to be compatible with the new spec :))

@steveklabnik
Copy link
Contributor

Will review this in the morning 😊😊😊

@ethanresnick
Copy link
Member

Fwiw—and I definitely don't mean to draw this out any longer than necessary—I do think we should settle #379 before we officially hit 1.0, as giving clients certainty around the meaning of resource isn't something we'll be able to change later.

@dgeb
Copy link
Member Author

dgeb commented Mar 6, 2015

Will review this in the morning

@steveklabnik absolutely... no need to rush after all this time. Please thoroughly review the commits pushed by myself and @wycats tonight.

@bintoro
Copy link
Contributor

bintoro commented Mar 6, 2015

Please also keep in mind that hitting 1.0 rules out any further enhancements that require new reserved keys in resource objects. Notably affected: #383. To sidestep the problem altogether: #313.

@dgeb dgeb added this to the 1.0 milestone Mar 6, 2015
@dgeb
Copy link
Member Author

dgeb commented Mar 6, 2015

Added a few more issues to the 1.0 milestone which we can review in detail before tagging.

Gotta fly for now ✈️

@hhware
Copy link
Contributor

hhware commented Mar 6, 2015

I humbly request to also consider the issue #415 (Attributes of to-many relationships) for inclusion to 1.0.

@bintoro
Copy link
Contributor

bintoro commented Mar 6, 2015

I don't think #415 is blocking 1.0.

That said, clauses about extra keys are starting to pop up all over the place, so I've filed PR #421 to move them all under a simple set of global rules. This also handily deals with #415. Not anymore.

@hhware
Copy link
Contributor

hhware commented Mar 6, 2015

@bintoro Thanks! Your PR #421 made me reconsider #415.

I hope there is still time left to suggest improvements for 1.0. If at all possible, I would like to have a chance to prepare a PR to present my proposal in #415 in a more clear form. I will definitely be able to do it by this Sunday, March 8.

@steveklabnik
Copy link
Contributor

This a teeny bit premature, closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants