fix #6282: calculate correct count for PoolArena's tiny/small/normal allocation #6288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| allocateNormal(buf, reqCapacity, normCapacity); | ||
| return; | ||
| } finally { | ||
| incTinySmallNormalAllocation(normCapacity); |
There was a problem hiding this comment.
@isdom I would prefer if we not need to acquire the synchronized(this) two times when we increment for normal allocations. Can you please refactor to ensure we not do ?
There was a problem hiding this comment.
@normanmaurer Could you give me some advice for my commit: acquire the synchronized(this) once when we increment for normal allocations?
|
@normanmaurer thanks for your adjustment. the code looks much better. |
|
@isdom no worries... thanks again for the help and the report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Disable ThreadLocal Cache, then allocate Pooled ByteBuf and release all these buffers, PoolArena's tiny/small/normal allocation count incorrect.
Modifications:
Result:
Fixes #6282 .