add binlog row minimal and noblob image support #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please fix and some tests? |
TypeError: unsupported operand type(s) for &: 'float' and 'int'
TypeError: 'float' object cannot be interpreted as an integer
TypeError: bytearray indices must be integers
|
Sorry that I have not used python for nearly 2 years and fixing errors for different python version drives me crazy 😢 |
|
|
||
| row["before_values"] = self._read_column_data(null_bitmap) | ||
| b = Bitmap(self.columns_present_bitmap, self.number_of_columns) |
There was a problem hiding this comment.
so b is the null_bitmap? Why not name it so :)
There was a problem hiding this comment.
b is null_bitmap, but named cols bitmap in mysql source, I will use it later. :-)
|
What do yo think about having some specific tests for |
|
Well, testing bitmap may be not easy, is it ok to test MySQL row image instead? |
|
@noplay what do you think? I think we can merge it :) |
|
You are right ! Sorry with christmas i was busy. |
julien-duponchelle
added a commit
that referenced
this pull request
Dec 29, 2014
add binlog row minimal and noblob image support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only test using python 2.7, mac osx.