Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Jersey dependencies from Eureka Client #1849

Closed
daniellavoie opened this issue Apr 11, 2017 · 0 comments
Closed

Remove Jersey dependencies from Eureka Client #1849

daniellavoie opened this issue Apr 11, 2017 · 0 comments
Labels
enhancement
Milestone
1.4.0.M1

Comments

@daniellavoie
Copy link
Contributor

daniellavoie commented Apr 11, 2017 •
edited

Since Netflix/eureka/pull/821, it is now possible to provide a custom implementation of EurekaHttpClient.

Out of the box, the eureka client provides implementations with Jersey1 and Jersey2. For Spring Cloud, it would make more sense to exclude Jersey and implement our own http client based on Spring RestTemplate.

This improvement would free us from Jersey's transitive dependencies inherited from the eureka-client.
@daniellavoie daniellavoie changed the title Remove Jersey dependency from Eureka Client Remove Jersey dependencies from Eureka Client Apr 11, 2017
@daniellavoie daniellavoie mentioned this issue Apr 11, 2017
Merged
daniellavoie added a commit to daniellavoie/spring-cloud-netflix that referenced this issue Apr 15, 2017
@daniellavoie
Remove Jersey dependencies from Eureka Client
2be945f 
Fixes spring-cloudgh-1849
spencergibb pushed a commit that referenced this issue Jul 21, 2017
@spencergibb
Optionally remove Jersey dependencies from Eureka Client (#1850)
348c96b 
Fixes gh-1849
@spencergibb spencergibb added this to the 1.4.0.M1 milestone Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.4.0.M1
Development

No branches or pull requests
2 participants
@spencergibb @daniellavoie