Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question: Do we need Feign retry? #129

Closed
eacdy opened this issue Sep 29, 2017 · 5 comments
Closed

question: Do we need Feign retry? #129

eacdy opened this issue Sep 29, 2017 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@eacdy
Copy link
Contributor

eacdy commented Sep 29, 2017

In this post: spring-cloud/spring-cloud-netflix#467 .

Since we've eliminated the feign retry with our ribbon retry, Do we still need the property below?

feign:
  client:
    config:
      feignName:
        retryer: com.example.SimpleRetryer

This property is from http://cloud.spring.io/spring-cloud-static/Edgware.M1/#spring-cloud-feign-overriding-defaults .

I think we should delete this property.

ping @spencergibb
@ryanjbaxter
Copy link
Contributor

I agree I think we can eliminate this. Want to submit a PR?

eacdy referenced this issue in itmuch/spring-cloud-netflix Oct 5, 2017
@itmuch001
fix https://github.com/spring-cloud/spring-cloud-netflix/issues/2330
f869b79
@eacdy
Copy link
Contributor Author

eacdy commented Oct 5, 2017

PR's coming. @ryanjbaxter

spring-cloud/spring-cloud-netflix#2344

@spencergibb
Copy link
Member

I don't know. I'd hate to remove an option even if the package provides one, there may be a case where someone wants this, why would we eliminate it?

@spencergibb spencergibb transferred this issue from spring-cloud/spring-cloud-netflix Jan 31, 2019
@spencergibb spencergibb added enhancement New feature or request help wanted Extra attention is needed labels Jan 31, 2019
@spring-projects-issues
Copy link

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues
Copy link

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ryanjbaxter @spencergibb @eacdy @spring-projects-issues