New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate RequestAttributes across Hystrix Thread boundary #2509
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2509 +/- ##
==========================================
- Coverage 65.65% 65.23% -0.42%
==========================================
Files 207 210 +3
Lines 7646 7695 +49
Branches 943 944 +1
==========================================
Hits 5020 5020
- Misses 2268 2317 +49
Partials 358 358
Continue to review full report at Codecov.
|
You will need to provide some tests |
need testing |
need to simplify it |
+1 |
@eacdy can you rebase and add a test? |
@spencergibb Sorry, I don't have enough time. Could you help me rebase and add a test? |
同时存在多个请求的时候,request 之间数据互串了?怎么解决呢? |
这份问题是测试出来的新bug吗? |
@hongtu1993 不是。 |
@zedongQ @hongtu1993 @eacdy @gaoyibing111 . Please only use English to comment on PRs in this repository. If you want us to take them into consideration, please translate your latest comments to English. The Spring Cloud Team does not speak the language you've used here. |
ok ,tks |
Well any new progress here? Workaround or will this be implemented some time? |
I don't think so. |
so,how to deal it ? |
Sometimes we need to get request attribute in feign's interceptor or other where else. So it's necessary to copy the attributes managed by the Spring RequestContextHolder from the main thread to the threads managed by Hystrix thread pool.
Inspired by #1379