Use a separate thread to get the topic offsets to fixed bug 'Yikes! Ask timed out...' #456
Conversation
…s! Ask timed out'
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
DavidLiuXh
changed the title
DavidLiuXh
changed the title
|
@patelh I believe this fixes a long time issue. Would be great to have a look at it |
|
@DavidLiuXh : When will this be merged into master ? |
|
anyone tried this besides DavidLiuXh? |
| var broker2TopicPartitionMap: Map[BrokerIdentity, List[(TopicAndPartition, PartitionOffsetRequestInfo)]] = Map() | ||
|
|
||
| data.asScala.keys.toIndexedSeq.foreach(topic => { | ||
| var optPartitionsWithLeaders : Option[List[(Int, Option[BrokerIdentity])]] = getPartitionLeaders(topic) |
There was a problem hiding this comment.
Maybe add another check here for shutdown. If the list of topics is long, it may take some time to shutdown.
| ) | ||
|
|
||
| broker2TopicPartitionMap.keys.foreach(broker => { | ||
| var tpList = broker2TopicPartitionMap(broker) |
There was a problem hiding this comment.
Same here, maybe add shutdown check to stop processing on close.
|
@patelh - I just built this and it seems to resolve the issue for me. No problems, everything seems to be working as expected |
Use a separate thread to get the topic offsets